diff options
| author | Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | 2019-10-10 11:29:01 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-10-10 11:29:01 +0100 |
| commit | a139420a3cfda6a4a4ee4750611b31dd71fc33f3 (patch) | |
| tree | 9129aff6a5e73673054a1c9125fa977099a2b7db /tests/rest/admin | |
| parent | Rewrite the user_filter migration again (#6184) (diff) | |
| download | synapse-a139420a3cfda6a4a4ee4750611b31dd71fc33f3.tar.xz | |
Fix races in room stats (and other) updates. (#6187)
Hopefully this will fix the occasional failures we were seeing in the room directory. The problem was that events are not necessarily persisted (and `current_state_delta_stream` updated) in the same order as their stream_id. So for instance current_state_delta 9 might be persisted *before* current_state_delta 8. Then, when the room stats saw stream_id 9, it assumed it had done everything up to 9, and never came back to do stream_id 8. We can solve this easily by only processing up to the stream_id where we know all events have been persisted.
Diffstat (limited to 'tests/rest/admin')
| -rw-r--r-- | tests/rest/admin/test_admin.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/rest/admin/test_admin.py b/tests/rest/admin/test_admin.py index 5877bb2133..d3a4f717f7 100644 --- a/tests/rest/admin/test_admin.py +++ b/tests/rest/admin/test_admin.py @@ -62,7 +62,7 @@ class UserRegisterTestCase(unittest.HomeserverTestCase): self.device_handler.check_device_registered = Mock(return_value="FAKE") self.datastore = Mock(return_value=Mock()) - self.datastore.get_current_state_deltas = Mock(return_value=[]) + self.datastore.get_current_state_deltas = Mock(return_value=(0, [])) self.secrets = Mock() |