diff options
| author | Sean Quah <8349537+squahtx@users.noreply.github.com> | 2023-02-10 23:29:00 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-10 23:29:00 +0000 |
| commit | d0c713cc85f094c323b2ba3f02d8ac411a7f0705 (patch) | |
| tree | c26f279f53c76ea9adb74853d11cfd264675eeb5 /tests/rest/admin | |
| parent | Support for MSC3758: exact_event_match push condition (#14964) (diff) | |
| download | synapse-d0c713cc85f094c323b2ba3f02d8ac411a7f0705.tar.xz | |
Return read-only collections from `@cached` methods (#13755)
It's important that collections returned from `@cached` methods are not modified, otherwise future retrievals from the cache will return the modified collection. This applies to the return values from `@cached` methods and the values inside the dictionaries returned by `@cachedList` methods. It's not necessary for the dictionaries returned by `@cachedList` methods themselves to be read-only. Signed-off-by: Sean Quah <seanq@matrix.org> Co-authored-by: David Robertson <davidr@element.io>
Diffstat (limited to 'tests/rest/admin')
| -rw-r--r-- | tests/rest/admin/test_server_notice.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/rest/admin/test_server_notice.py b/tests/rest/admin/test_server_notice.py index a2f347f666..f71ff46d87 100644 --- a/tests/rest/admin/test_server_notice.py +++ b/tests/rest/admin/test_server_notice.py @@ -11,7 +11,7 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. -from typing import List +from typing import List, Sequence from twisted.test.proto_helpers import MemoryReactor @@ -558,7 +558,7 @@ class ServerNoticeTestCase(unittest.HomeserverTestCase): def _check_invite_and_join_status( self, user_id: str, expected_invites: int, expected_memberships: int - ) -> List[RoomsForUser]: + ) -> Sequence[RoomsForUser]: """Check invite and room membership status of a user. Args |