diff options
| author | Richard van der Hoff <richard@matrix.org> | 2020-12-15 14:51:25 +0000 |
|---|---|---|
| committer | Richard van der Hoff <richard@matrix.org> | 2020-12-15 22:32:12 +0000 |
| commit | 7eebe4b3fc3129e4571d58c3cea5eeccc584e072 (patch) | |
| tree | 3dff8e5f146206d5724162f859491bd22a52f4a9 /tests/replication/test_client_reader_shard.py | |
| parent | Preparatory refactoring of the SamlHandlerTestCase (#8938) (diff) | |
| download | synapse-7eebe4b3fc3129e4571d58c3cea5eeccc584e072.tar.xz | |
Replace `request.code` with `channel.code`
The two are equivalent, but really we want to check the HTTP result that got returned to the channel, not the code that the Request object *intended* to return to the channel.
Diffstat (limited to 'tests/replication/test_client_reader_shard.py')
| -rw-r--r-- | tests/replication/test_client_reader_shard.py | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/tests/replication/test_client_reader_shard.py b/tests/replication/test_client_reader_shard.py index fdaad3d8ad..6cdf6a099b 100644 --- a/tests/replication/test_client_reader_shard.py +++ b/tests/replication/test_client_reader_shard.py @@ -48,7 +48,7 @@ class ClientReaderTestCase(BaseMultiWorkerStreamTestCase): "register", {"username": "user", "type": "m.login.password", "password": "bar"}, ) # type: SynapseRequest, FakeChannel - self.assertEqual(request_1.code, 401) + self.assertEqual(channel_1.code, 401) # Grab the session session = channel_1.json_body["session"] @@ -61,7 +61,7 @@ class ClientReaderTestCase(BaseMultiWorkerStreamTestCase): "register", {"auth": {"session": session, "type": "m.login.dummy"}}, ) # type: SynapseRequest, FakeChannel - self.assertEqual(request_2.code, 200) + self.assertEqual(channel_2.code, 200) # We're given a registered user. self.assertEqual(channel_2.json_body["user_id"], "@user:test") @@ -80,7 +80,7 @@ class ClientReaderTestCase(BaseMultiWorkerStreamTestCase): "register", {"username": "user", "type": "m.login.password", "password": "bar"}, ) # type: SynapseRequest, FakeChannel - self.assertEqual(request_1.code, 401) + self.assertEqual(channel_1.code, 401) # Grab the session session = channel_1.json_body["session"] @@ -94,7 +94,7 @@ class ClientReaderTestCase(BaseMultiWorkerStreamTestCase): "register", {"auth": {"session": session, "type": "m.login.dummy"}}, ) # type: SynapseRequest, FakeChannel - self.assertEqual(request_2.code, 200) + self.assertEqual(channel_2.code, 200) # We're given a registered user. self.assertEqual(channel_2.json_body["user_id"], "@user:test") |