summary refs log tree commit diff
path: root/tests/replication/_base.py
diff options
context:
space:
mode:
authorDavid Robertson <davidr@element.io>2021-09-30 12:51:47 +0100
committerGitHub <noreply@github.com>2021-09-30 12:51:47 +0100
commit29364145b29e84c5dcab076c4e0d436ebf77e4cd (patch)
tree23ef1af431c4629bf973560c86a5cf801e80b3a5 /tests/replication/_base.py
parentRefactor user directory tests (#10935) (diff)
downloadsynapse-29364145b29e84c5dcab076c4e0d436ebf77e4cd.tar.xz
Pass str to twisted's IReactorTCP (#10895)
This follows a correction made in twisted/twisted#1664 and should fix our Twisted Trial CI job.

Until that change is in a twisted release, we'll have to ignore the type
of the `host` argument. I've raised #10899 to remind us to review the
issue in a few months' time.
Diffstat (limited to 'tests/replication/_base.py')
-rw-r--r--tests/replication/_base.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/replication/_base.py b/tests/replication/_base.py
index c7555c26db..cdd6e3d3c1 100644
--- a/tests/replication/_base.py
+++ b/tests/replication/_base.py
@@ -240,7 +240,7 @@ class BaseMultiWorkerStreamTestCase(unittest.HomeserverTestCase):
         if self.hs.config.redis.redis_enabled:
             # Handle attempts to connect to fake redis server.
             self.reactor.add_tcp_client_callback(
-                b"localhost",
+                "localhost",
                 6379,
                 self.connect_any_redis_attempts,
             )
@@ -424,7 +424,7 @@ class BaseMultiWorkerStreamTestCase(unittest.HomeserverTestCase):
         clients = self.reactor.tcpClients
         while clients:
             (host, port, client_factory, _timeout, _bindAddress) = clients.pop(0)
-            self.assertEqual(host, b"localhost")
+            self.assertEqual(host, "localhost")
             self.assertEqual(port, 6379)
 
             client_protocol = client_factory.buildProtocol(None)