summary refs log tree commit diff
path: root/tests/events/test_utils.py
diff options
context:
space:
mode:
authorErik Johnston <erik@matrix.org>2020-04-29 14:10:59 +0100
committerGitHub <noreply@github.com>2020-04-29 14:10:59 +0100
commit3eab76ad43e1de4074550c468d11318d497ff632 (patch)
tree919ff2563327b2cef97a1c1625122fdc4fe7815f /tests/events/test_utils.py
parentFix limit logic for EventsStream (#7358) (diff)
downloadsynapse-3eab76ad43e1de4074550c468d11318d497ff632.tar.xz
Don't relay REMOTE_SERVER_UP cmds to same conn. (#7352)
For direct TCP connections we need the master to relay REMOTE_SERVER_UP
commands to the other connections so that all instances get notified
about it. The old implementation just relayed to all connections,
assuming that sending back to the original sender of the command was
safe. This is not true for redis, where commands sent get echoed back to
the sender, which was causing master to effectively infinite loop
sending and then re-receiving REMOTE_SERVER_UP commands that it sent.

The fix is to ensure that we only relay to *other* connections and not
to the connection we received the notification from.

Fixes #7334.
Diffstat (limited to 'tests/events/test_utils.py')
0 files changed, 0 insertions, 0 deletions