summary refs log tree commit diff
path: root/synapse
diff options
context:
space:
mode:
authorErik Johnston <erik@matrix.org>2019-07-22 14:52:52 +0100
committerGitHub <noreply@github.com>2019-07-22 14:52:52 +0100
commit720d30469f7246f2a8cb2dc76021885322d8c158 (patch)
tree760ed0a23da81517154b1689670c3ea82ba3a395 /synapse
parentMerge pull request #5731 from matrix-org/jaywink/admin-user-list-user-type (diff)
parentUpdate changelog.d/5730.misc (diff)
downloadsynapse-720d30469f7246f2a8cb2dc76021885322d8c158.tar.xz
Merge pull request #5730 from matrix-org/erikj/cache_versions
Cache get_version_string.
Diffstat (limited to 'synapse')
-rw-r--r--synapse/util/versionstring.py23
1 files changed, 21 insertions, 2 deletions
diff --git a/synapse/util/versionstring.py b/synapse/util/versionstring.py
index a4d9a462f7..fa404b9d75 100644
--- a/synapse/util/versionstring.py
+++ b/synapse/util/versionstring.py
@@ -22,6 +22,23 @@ logger = logging.getLogger(__name__)
 
 
 def get_version_string(module):
+    """Given a module calculate a git-aware version string for it.
+
+    If called on a module not in a git checkout will return `__verison__`.
+
+    Args:
+        module (module)
+
+    Returns:
+        str
+    """
+
+    cached_version = getattr(module, "_synapse_version_string_cache", None)
+    if cached_version:
+        return cached_version
+
+    version_string = module.__version__
+
     try:
         null = open(os.devnull, "w")
         cwd = os.path.dirname(os.path.abspath(module.__file__))
@@ -80,8 +97,10 @@ def get_version_string(module):
                 s for s in (git_branch, git_tag, git_commit, git_dirty) if s
             )
 
-            return "%s (%s)" % (module.__version__, git_version)
+            version_string = "%s (%s)" % (module.__version__, git_version)
     except Exception as e:
         logger.info("Failed to check for git repository: %s", e)
 
-    return module.__version__
+    module._synapse_version_string_cache = version_string
+
+    return version_string