summary refs log tree commit diff
path: root/synapse
diff options
context:
space:
mode:
authorErik Johnston <erik@matrix.org>2019-02-22 11:33:51 +0000
committerErik Johnston <erik@matrix.org>2019-02-22 11:33:51 +0000
commit7b288826b76cae63b553fced10d3779355b592ca (patch)
treec7e8c467e3e2231e1260121ead08b76897af8885 /synapse
parentAdd prometheus metrics for number of badge update pushes. (#4709) (diff)
downloadsynapse-7b288826b76cae63b553fced10d3779355b592ca.tar.xz
Fix backfill storing incorrect state for events
Diffstat (limited to 'synapse')
-rw-r--r--synapse/handlers/federation.py5
1 files changed, 4 insertions, 1 deletions
diff --git a/synapse/handlers/federation.py b/synapse/handlers/federation.py
index 083f2e0ac3..40655bf92c 100644
--- a/synapse/handlers/federation.py
+++ b/synapse/handlers/federation.py
@@ -772,8 +772,11 @@ class FederationHandler(BaseHandler):
 
         ev_infos = []
         for a in auth_events.values():
-            if a.event_id in seen_events:
+            # We only want to persist auth events as outliers that we haven't
+            # seen and aren't about to persist as part of the backfilled chunk.
+            if a.event_id in seen_events or a.event_id in event_map:
                 continue
+
             a.internal_metadata.outlier = True
             ev_infos.append({
                 "event": a,