summary refs log tree commit diff
path: root/synapse
diff options
context:
space:
mode:
authorHillery Shay <shaysquared@gmail.com>2021-09-21 08:04:35 -0700
committerGitHub <noreply@github.com>2021-09-21 08:04:35 -0700
commit5fca3c8ae62c66a1777bcb85c98679669369b061 (patch)
tree41d44719f28401b6d4be0273c1d0a12158d36ee5 /synapse
parentRename `/batch_send` query parameter from `?prev_event` to more obvious usage... (diff)
downloadsynapse-5fca3c8ae62c66a1777bcb85c98679669369b061.tar.xz
Allow Synapse Admin API's Room Search to accept non-ASCII characters (#10859)
* add tests for checking if room search works with non-ascii char

* change encoding on parse_string to UTF-8

* lints

* properly encode search term

* lints

* add changelog file

* update changelog number

* set changelog entry filetype to .bugfix

* Revert "set changelog entry filetype to .bugfix"

This reverts commit be8e5a314251438ec4ec7dbc59ba32162c93e550.

* update changelog message and file type

* change parse_string default encoding back to ascii and update room search admin api calll to parse string

* refactor tests

* Update tests/rest/admin/test_room.py

Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>

Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
Diffstat (limited to 'synapse')
-rw-r--r--synapse/rest/admin/rooms.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/synapse/rest/admin/rooms.py b/synapse/rest/admin/rooms.py
index ad83d4b54c..8f781f745f 100644
--- a/synapse/rest/admin/rooms.py
+++ b/synapse/rest/admin/rooms.py
@@ -125,7 +125,7 @@ class ListRoomRestServlet(RestServlet):
                 errcode=Codes.INVALID_PARAM,
             )
 
-        search_term = parse_string(request, "search_term")
+        search_term = parse_string(request, "search_term", encoding="utf-8")
         if search_term == "":
             raise SynapseError(
                 400,