diff options
| author | Patrick Cloke <clokep@users.noreply.github.com> | 2022-08-30 07:15:54 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-08-30 07:15:54 -0400 |
| commit | 303b40b988bc372a81fc1a3cf62d3f5d074970ff (patch) | |
| tree | 9fac44d56c449b7e11732f068283322ecb265386 /synapse | |
| parent | Speed up inserting `event_push_actions_staging`. (#13634) (diff) | |
| download | synapse-303b40b988bc372a81fc1a3cf62d3f5d074970ff.tar.xz | |
Do not wait for background updates to complete do expire URL cache. (#13657)
Media downloaded as part of a URL preview is normally deleted after two days. However, while a background database migration is running, the process is stopped. A long-running database migration can therefore cause the media store to fill up with old preview files. This logic was added in #2697 to make sure that we didn't try to run the expiry without an index on `local_media_repository.created_ts`; the original logic that needs that index was added in #2478 (in `get_url_cache_media_before`, as amended by 93247a424a5068b088567fa98b6990e47608b7cb), and is still present. Given that the background update was added before Synapse v1.0.0, just drop this check and assume the index exists.
Diffstat (limited to 'synapse')
| -rw-r--r-- | synapse/rest/media/v1/preview_url_resource.py | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/synapse/rest/media/v1/preview_url_resource.py b/synapse/rest/media/v1/preview_url_resource.py index b36c98a08e..a8f6fd6b35 100644 --- a/synapse/rest/media/v1/preview_url_resource.py +++ b/synapse/rest/media/v1/preview_url_resource.py @@ -732,10 +732,6 @@ class PreviewUrlResource(DirectServeJsonResource): logger.debug("Running url preview cache expiry") - if not (await self.store.db_pool.updates.has_completed_background_updates()): - logger.debug("Still running DB updates; skipping url preview cache expiry") - return - def try_remove_parent_dirs(dirs: Iterable[str]) -> None: """Attempt to remove the given chain of parent directories |