diff options
| author | FadhlanR <fridhwanallah@gmail.com> | 2024-01-02 23:25:26 +0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-01-02 16:25:26 +0000 |
| commit | eabedd9520ec56e3b52153ab823124bee9e7148a (patch) | |
| tree | 13f68e7236437ee72ed61ccf2591205d42fd5a05 /synapse | |
| parent | Re-enable automatic triaging (diff) | |
| download | synapse-eabedd9520ec56e3b52153ab823124bee9e7148a.tar.xz | |
Fix email verification redirection (#16761)
Previously, the response status of `HTMLResource` was hardcoded as `200`. However, for proper redirection after the user verifies their email, we require the status to be `302`. This PR addresses that issue by using `code` as response status.
Diffstat (limited to 'synapse')
| -rw-r--r-- | synapse/http/server.py | 2 | ||||
| -rw-r--r-- | synapse/rest/synapse/client/password_reset.py | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/synapse/http/server.py b/synapse/http/server.py index d570bf5e62..31311aeb2a 100644 --- a/synapse/http/server.py +++ b/synapse/http/server.py @@ -574,7 +574,7 @@ class DirectServeHtmlResource(_AsyncResource): assert isinstance(response_object, bytes) html_bytes = response_object - respond_with_html_bytes(request, 200, html_bytes) + respond_with_html_bytes(request, code, html_bytes) def _send_error_response( self, diff --git a/synapse/rest/synapse/client/password_reset.py b/synapse/rest/synapse/client/password_reset.py index f6bdccad30..671eae7c07 100644 --- a/synapse/rest/synapse/client/password_reset.py +++ b/synapse/rest/synapse/client/password_reset.py @@ -106,7 +106,7 @@ class PasswordResetSubmitTokenResource(DirectServeHtmlResource): return ( 302, ( - b'You are being redirected to <a src="%s">%s</a>.' + b'You are being redirected to <a href="%s">%s</a>.' % (next_link_bytes, next_link_bytes) ), ) |