diff options
author | Erik Johnston <erik@matrix.org> | 2020-09-16 11:56:23 +0100 |
---|---|---|
committer | Erik Johnston <erik@matrix.org> | 2020-09-16 11:56:23 +0100 |
commit | c570f24acc276e204d9fe743c2ea5c369407be08 (patch) | |
tree | fa24838bc5415fd6058734bc4c34f848ce00f40e /synapse | |
parent | 1.19.1 (diff) | |
download | synapse-c570f24acc276e204d9fe743c2ea5c369407be08.tar.xz |
Don't assume that an event has an origin field
This fixes #8319.
Diffstat (limited to 'synapse')
-rw-r--r-- | synapse/federation/federation_client.py | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/synapse/federation/federation_client.py b/synapse/federation/federation_client.py index 38ac7ec699..a2e8d96ea2 100644 --- a/synapse/federation/federation_client.py +++ b/synapse/federation/federation_client.py @@ -54,7 +54,7 @@ from synapse.events import EventBase, builder from synapse.federation.federation_base import FederationBase, event_from_pdu_json from synapse.logging.context import make_deferred_yieldable, preserve_fn from synapse.logging.utils import log_function -from synapse.types import JsonDict +from synapse.types import JsonDict, get_domain_from_id from synapse.util import unwrapFirstError from synapse.util.caches.expiringcache import ExpiringCache from synapse.util.retryutils import NotRetryingDestination @@ -386,10 +386,11 @@ class FederationClient(FederationBase): pdu.event_id, allow_rejected=True, allow_none=True ) - if not res and pdu.origin != origin: + pdu_origin = get_domain_from_id(pdu.sender) + if not res and pdu_origin != origin: try: res = await self.get_pdu( - destinations=[pdu.origin], + destinations=[pdu_origin], event_id=pdu.event_id, room_version=room_version, outlier=outlier, |