diff options
| author | Jason Robinson <jasonr@element.io> | 2021-09-24 12:41:18 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-09-24 10:41:18 +0100 |
| commit | fa7453638408c2c55fade2d20dba362ff23226e5 (patch) | |
| tree | 138bd483c4e901cf69fd1d806de85c1c6b887460 /synapse | |
| parent | Improve typing in user_directory files (#10891) (diff) | |
| download | synapse-fa7453638408c2c55fade2d20dba362ff23226e5.tar.xz | |
Fix AuthBlocking check when requester is appservice (#10881)
If the MAU count had been reached, Synapse incorrectly blocked appservice users even though they've been explicitly configured not to be tracked (the default). This was due to bypassing the relevant if as it was chained behind another earlier hit if as an elif. Signed-off-by: Jason Robinson <jasonr@matrix.org>
Diffstat (limited to 'synapse')
| -rw-r--r-- | synapse/api/auth_blocking.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/synapse/api/auth_blocking.py b/synapse/api/auth_blocking.py index a3b95f4de0..08fe160c98 100644 --- a/synapse/api/auth_blocking.py +++ b/synapse/api/auth_blocking.py @@ -81,7 +81,7 @@ class AuthBlocking: # We never block the server from doing actions on behalf of # users. return - elif requester.app_service and not self._track_appservice_user_ips: + if requester.app_service and not self._track_appservice_user_ips: # If we're authenticated as an appservice then we only block # auth if `track_appservice_user_ips` is set, as that option # implicitly means that application services are part of MAU |