Send mail notifs with a plaintext part too

2 files changed, 22 insertions, 7 deletions

diff --git a/synapse/config/emailconfig.py b/synapse/config/emailconfig.py
index 06b076e3f9..b7be67f173 100644
--- a/synapse/config/emailconfig.py
+++ b/synapse/config/emailconfig.py
@@ -38,6 +38,7 @@ class EmailConfig(Config):
                 "notif_from",
                 "template_dir",
                 "notif_template_html",
+                "notif_template_text",
             ]
 
             missing = []
@@ -61,6 +62,7 @@ class EmailConfig(Config):
             self.email_notif_from = email_config["notif_from"]
             self.email_template_dir = email_config["template_dir"]
             self.email_notif_template_html = email_config["notif_template_html"]
+            self.email_notif_template_text = email_config["notif_template_text"]
 
             # make sure it's valid
             parsed = email.utils.parseaddr(self.email_notif_from)
diff --git a/synapse/push/mailer.py b/synapse/push/mailer.py
index c53ae9a547..4fd89b3e90 100644
--- a/synapse/push/mailer.py
+++ b/synapse/push/mailer.py
@@ -19,6 +19,7 @@ from twisted.mail.smtp import sendmail
 import email.utils
 import email.mime.multipart
 from email.mime.text import MIMEText
+from email.mime.multipart import MIMEMultipart
 
 from synapse.util.async import concurrently_execute
 from synapse.util.presentable_names import (
@@ -74,7 +75,12 @@ class Mailer(object):
         env = jinja2.Environment(loader=loader)
         env.filters["format_ts"] = format_ts_filter
         env.filters["mxc_to_http"] = self.mxc_to_http_filter
-        self.notif_template = env.get_template(self.hs.config.email_notif_template_html)
+        self.notif_template_html = env.get_template(
+            self.hs.config.email_notif_template_html
+        )
+        self.notif_template_text = env.get_template(
+            self.hs.config.email_notif_template_text
+        )
 
     @defer.inlineCallbacks
     def send_notification_mail(self, user_id, email_address, push_actions):
@@ -135,16 +141,23 @@ class Mailer(object):
             "rooms": rooms,
         }
 
-        plainText = self.notif_template.render(**template_vars)
+        html_text = self.notif_template_html.render(**template_vars)
+        html_part = MIMEText(html_text, "html", "utf8")
+
+        plain_text = self.notif_template_text.render(**template_vars)
+        text_part = MIMEText(plain_text, "plain", "utf8")
+
+        multipart_msg = MIMEMultipart('alternative')
+        multipart_msg['Subject'] = "New Matrix Notifications"
+        multipart_msg['From'] = self.hs.config.email_notif_from
+        multipart_msg['To'] = email_address
+        multipart_msg.attach(text_part)
+        multipart_msg.attach(html_part)
 
-        text_part = MIMEText(plainText, "html", "utf8")
-        text_part['Subject'] = "New Matrix Notifications"
-        text_part['From'] = self.hs.config.email_notif_from
-        text_part['To'] = email_address
 
         yield sendmail(
             self.hs.config.email_smtp_host,
-            raw_from, raw_to, text_part.as_string(),
+            raw_from, raw_to, multipart_msg.as_string(),
             port=self.hs.config.email_smtp_port
         )