summary refs log tree commit diff
path: root/synapse
diff options
context:
space:
mode:
authorErik Johnston <erik@matrix.org>2017-05-05 10:59:32 +0100
committerErik Johnston <erik@matrix.org>2017-05-05 10:59:32 +0100
commitb843631d7157f0beb64db62a86c691369aa49b14 (patch)
tree02afa0d356c10bbc5f2440bfa78e6cc869a78959 /synapse
parentHandle exceptions thrown in handling remote device list updates (diff)
downloadsynapse-b843631d7157f0beb64db62a86c691369aa49b14.tar.xz
Add comment and TODO
Diffstat (limited to '')
-rw-r--r--synapse/handlers/device.py6
1 files changed, 6 insertions, 0 deletions
diff --git a/synapse/handlers/device.py b/synapse/handlers/device.py
index 72915b85d8..187af03fb1 100644
--- a/synapse/handlers/device.py
+++ b/synapse/handlers/device.py
@@ -426,6 +426,8 @@ class DeviceListEduUpdater(object):
                 # This can happen since we batch updates
                 return
 
+            # Given a list of updates we check if we need to resync. This
+            # happens if we've missed updates.
             resync = yield self._need_to_do_resync(user_id, pending_updates)
 
             if resync:
@@ -434,6 +436,8 @@ class DeviceListEduUpdater(object):
                 try:
                     result = yield self.federation.query_user_devices(origin, user_id)
                 except NotRetryingDestination:
+                    # TODO: Remember that we are now out of sync and try again
+                    # later
                     logger.warn(
                         "Failed to handle device list update for %s,"
                         " we're not retrying the remote",
@@ -441,6 +445,8 @@ class DeviceListEduUpdater(object):
                     )
                     return
                 except Exception:
+                    # TODO: Remember that we are now out of sync and try again
+                    # later
                     logger.exception(
                         "Failed to handle device list update for %s", user_id
                     )