summary refs log tree commit diff
path: root/synapse
diff options
context:
space:
mode:
authorRichard van der Hoff <1389908+richvdh@users.noreply.github.com>2022-04-29 22:05:18 +0100
committerGitHub <noreply@github.com>2022-04-29 22:05:18 +0100
commit8d156ec0ba17d848581f18aa40ebfd76dda763d4 (patch)
treef4a90f8ea59c808eb1f0a8d756c59763558f9615 /synapse
parentAllow unused ignores in "bleeding edge" CI (#12576) (diff)
downloadsynapse-8d156ec0ba17d848581f18aa40ebfd76dda763d4.tar.xz
Remove special-case for `twisted` logger (#12589)
This was originally added when we first added a `MemoryHandler` to the default
log config back in https://github.com/matrix-org/synapse/pull/8040, to ensure
that we didn't explode with an infinite loop if there was an error formatting
the logs.

Since then, we made additional improvements to logging which make this
workaround redundant. In particular:

 * we no longer attempt to log un-UTF8-decodable byte sequences, which were the
   most likely cause of an error in the first place.

 * https://github.com/matrix-org/synapse/pull/8268 ensures that in the unlikely
   case that there *is* an error, it won't cause an infinite loop.
Diffstat (limited to '')
-rw-r--r--synapse/config/logger.py7
1 files changed, 0 insertions, 7 deletions
diff --git a/synapse/config/logger.py b/synapse/config/logger.py
index 99db9e1e39..470b8b4492 100644
--- a/synapse/config/logger.py
+++ b/synapse/config/logger.py
@@ -110,13 +110,6 @@ loggers:
         # information such as access tokens.
         level: INFO
 
-    twisted:
-        # We send the twisted logging directly to the file handler,
-        # to work around https://github.com/matrix-org/synapse/issues/3471
-        # when using "buffer" logger. Use "console" to log to stderr instead.
-        handlers: [file]
-        propagate: false
-
 root:
     level: INFO