diff options
| author | Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> | 2019-10-30 11:00:15 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-10-30 11:00:15 +0000 |
| commit | b39ca49db167e814d7848c6a4872c8b65ec03ff1 (patch) | |
| tree | 2c6b70ee8ce080f706e9be5baa6409f8dd078381 /synapse/util | |
| parent | Merge pull request #6280 from matrix-org/erikj/receipts_async_await (diff) | |
| download | synapse-b39ca49db167e814d7848c6a4872c8b65ec03ff1.tar.xz | |
Handle FileNotFound error in checking git repository version (#6284)
Diffstat (limited to 'synapse/util')
| -rw-r--r-- | synapse/util/versionstring.py | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/synapse/util/versionstring.py b/synapse/util/versionstring.py index fa404b9d75..ab7d03af3a 100644 --- a/synapse/util/versionstring.py +++ b/synapse/util/versionstring.py @@ -42,6 +42,7 @@ def get_version_string(module): try: null = open(os.devnull, "w") cwd = os.path.dirname(os.path.abspath(module.__file__)) + try: git_branch = ( subprocess.check_output( @@ -51,7 +52,8 @@ def get_version_string(module): .decode("ascii") ) git_branch = "b=" + git_branch - except subprocess.CalledProcessError: + except (subprocess.CalledProcessError, FileNotFoundError): + # FileNotFoundError can arise when git is not installed git_branch = "" try: @@ -63,7 +65,7 @@ def get_version_string(module): .decode("ascii") ) git_tag = "t=" + git_tag - except subprocess.CalledProcessError: + except (subprocess.CalledProcessError, FileNotFoundError): git_tag = "" try: @@ -74,7 +76,7 @@ def get_version_string(module): .strip() .decode("ascii") ) - except subprocess.CalledProcessError: + except (subprocess.CalledProcessError, FileNotFoundError): git_commit = "" try: @@ -89,7 +91,7 @@ def get_version_string(module): ) git_dirty = "dirty" if is_dirty else "" - except subprocess.CalledProcessError: + except (subprocess.CalledProcessError, FileNotFoundError): git_dirty = "" if git_branch or git_tag or git_commit or git_dirty: |