summary refs log tree commit diff
path: root/synapse/util
diff options
context:
space:
mode:
authorErik Johnston <erik@matrix.org>2018-09-21 14:19:46 +0100
committerErik Johnston <erik@matrix.org>2018-09-21 14:19:46 +0100
commit8601c24287c452c0d9a803b130e0f68cf6169f6a (patch)
tree5651cf7a06b3be5db0d04a61cf94bf4eddc843ba /synapse/util
parentMerge pull request #3927 from matrix-org/erikj/handle_background_errors (diff)
downloadsynapse-8601c24287c452c0d9a803b130e0f68cf6169f6a.tar.xz
Fix some instances of ExpiringCache not expiring cache items
ExpiringCache required that `start()` be called before it would actually
start expiring entries. A number of places didn't do that.

This PR removes `start` from ExpiringCache, and automatically starts
backround reaping process on creation instead.
Diffstat (limited to 'synapse/util')
-rw-r--r--synapse/util/caches/expiringcache.py1
1 files changed, 0 insertions, 1 deletions
diff --git a/synapse/util/caches/expiringcache.py b/synapse/util/caches/expiringcache.py
index ce85b2ae11..921a9c5b29 100644
--- a/synapse/util/caches/expiringcache.py
+++ b/synapse/util/caches/expiringcache.py
@@ -58,7 +58,6 @@ class ExpiringCache(object):
 
         self.metrics = register_cache("expiring", cache_name, self)
 
-    def start(self):
         if not self._expiry_ms:
             # Don't bother starting the loop if things never expire
             return