summary refs log tree commit diff
path: root/synapse/storage
diff options
context:
space:
mode:
authorErik Johnston <erik@matrix.org>2019-01-22 16:20:33 +0000
committerErik Johnston <erik@matrix.org>2019-01-22 16:20:33 +0000
commit1c9704f8ab72047a83c6a3b364f3693b332434f2 (patch)
treeaebbbcaafc2e7461be8a0b4819f439ff8f5cc4d8 /synapse/storage
parentNewsfile (diff)
downloadsynapse-1c9704f8ab72047a83c6a3b364f3693b332434f2.tar.xz
Don't shadow params
Diffstat (limited to 'synapse/storage')
-rw-r--r--synapse/storage/client_ips.py7
1 files changed, 3 insertions, 4 deletions
diff --git a/synapse/storage/client_ips.py b/synapse/storage/client_ips.py
index 9548cfd3f8..c485211175 100644
--- a/synapse/storage/client_ips.py
+++ b/synapse/storage/client_ips.py
@@ -151,7 +151,7 @@ class ClientIpStore(background_updates.BackgroundUpdateStore):
         else:
             last = False
 
-        def remove(txn, begin_last_seen, end_last_seen):
+        def remove(txn):
             # This works by looking at all entries in the given time span, and
             # then for each (user_id, access_token, ip) tuple in that range
             # checking for any duplicates in the rest of the table (via a join).
@@ -204,9 +204,8 @@ class ClientIpStore(background_updates.BackgroundUpdateStore):
                 txn, "user_ips_remove_dupes", {"last_seen": end_last_seen}
             )
 
-        yield self.runInteraction(
-            "user_ips_dups_remove", remove, begin_last_seen, end_last_seen
-        )
+        yield self.runInteraction("user_ips_dups_remove", remove)
+
         if last:
             yield self._end_background_update("user_ips_remove_dupes")