diff options
| author | Matthew Hodgson <matthew@matrix.org> | 2018-07-19 19:03:50 +0100 |
|---|---|---|
| committer | Matthew Hodgson <matthew@matrix.org> | 2018-07-19 19:03:50 +0100 |
| commit | bcaec2915ac74937171e27d507b8f9c0e39d3677 (patch) | |
| tree | 79ef714c0c097112dedb4c4b9c237cd15a127a15 /synapse/storage | |
| parent | add a filtered_types param to limit filtering to specific types (diff) | |
| download | synapse-bcaec2915ac74937171e27d507b8f9c0e39d3677.tar.xz | |
incorporate review
Diffstat (limited to 'synapse/storage')
| -rw-r--r-- | synapse/storage/state.py | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/synapse/storage/state.py b/synapse/storage/state.py index ee531a2ce0..75c6366e7a 100644 --- a/synapse/storage/state.py +++ b/synapse/storage/state.py @@ -545,9 +545,10 @@ class StateGroupWorkerStore(SQLBaseStore): if state_key is None: type_to_key[typ] = None - # XXX: why do we mark the type as missing from our cache just - # because we weren't filtering on a specific value of state_key? - # is it because the cache doesn't handle wildcards? + # we mark the type as missing from the cache because + # when the cache was populated it might have been done with a + # restricted set of state_keys, so the wildcard will not work + # and the cache may be incomplete. missing_types.add(key) else: if type_to_key.get(typ, object()) is not None: |