diff options
| author | Erik Johnston <erik@matrix.org> | 2020-10-12 15:51:41 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-10-12 15:51:41 +0100 |
| commit | 8de3703d214c814ad637793a0cc2220e20579ffa (patch) | |
| tree | 3daec0f9a8d7baf92f8746b12c8b54d92b8d7d6d /synapse/storage/util/sequence.py | |
| parent | Docker: support passing additional commandline args to synapse (#8390) (diff) | |
| download | synapse-8de3703d214c814ad637793a0cc2220e20579ffa.tar.xz | |
Make event persisters periodically announce position over replication. (#8499)
Currently background proccesses stream the events stream use the "minimum persisted position" (i.e. `get_current_token()`) rather than the vector clock style tokens. This is broadly fine as it doesn't matter if the background processes lag a small amount. However, in extreme cases (i.e. SyTests) where we only write to one event persister the background processes will never make progress. This PR changes it so that the `MultiWriterIDGenerator` keeps the current position of a given instance as up to date as possible (i.e using the latest token it sees if its not in the process of persisting anything), and then periodically announces that over replication. This then allows the "minimum persisted position" to advance, albeit with a small lag.
Diffstat (limited to 'synapse/storage/util/sequence.py')
| -rw-r--r-- | synapse/storage/util/sequence.py | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/synapse/storage/util/sequence.py b/synapse/storage/util/sequence.py index ff2d038ad2..4386b6101e 100644 --- a/synapse/storage/util/sequence.py +++ b/synapse/storage/util/sequence.py @@ -126,6 +126,8 @@ class PostgresSequenceGenerator(SequenceGenerator): if max_stream_id > last_value: logger.warning( "Postgres sequence %s is behind table %s: %d < %d", + self._sequence_name, + table, last_value, max_stream_id, ) |