diff options
| author | Erik Johnston <erik@matrix.org> | 2018-09-19 14:16:34 +0100 |
|---|---|---|
| committer | Erik Johnston <erik@matrix.org> | 2018-09-19 14:22:57 +0100 |
| commit | b9158ac2bf46e15107162be136964c17bd8a948c (patch) | |
| tree | a6d3ef4e7f13084906fb41b0080118616635a52c /synapse/storage/transactions.py | |
| parent | update changelog for #3909 (diff) | |
| download | synapse-b9158ac2bf46e15107162be136964c17bd8a948c.tar.xz | |
Remove get_destination_retry_timings cache
Currently we rely on the master to invalidate this cache promptly. However, after having moved most federation endpoints off of master this no longer happens, causing outbound fedeariont to get blackholed. Fixes #3798
Diffstat (limited to 'synapse/storage/transactions.py')
| -rw-r--r-- | synapse/storage/transactions.py | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/synapse/storage/transactions.py b/synapse/storage/transactions.py index 0c42bd3322..7d51f9612a 100644 --- a/synapse/storage/transactions.py +++ b/synapse/storage/transactions.py @@ -156,7 +156,6 @@ class TransactionStore(SQLBaseStore): """ pass - @cached(max_entries=10000) def get_destination_retry_timings(self, destination): """Gets the current retry timings (if any) for a given destination. @@ -212,10 +211,6 @@ class TransactionStore(SQLBaseStore): retry_last_ts, retry_interval): self.database_engine.lock_table(txn, "destinations") - self._invalidate_cache_and_stream( - txn, self.get_destination_retry_timings, (destination,) - ) - # We need to be careful here as the data may have changed from under us # due to a worker setting the timings. |