summary refs log tree commit diff
path: root/synapse/storage/stream.py
diff options
context:
space:
mode:
authorRichard van der Hoff <richard@matrix.org>2018-10-12 09:55:41 +0100
committerRichard van der Hoff <richard@matrix.org>2018-10-12 09:55:41 +0100
commit8ddd0f273c501b83b75a58e379d73aef3cfab35e (patch)
tree905cd19f69d21cf94399418688dc051bd99d9c92 /synapse/storage/stream.py
parentMerge pull request #4022 from matrix-org/erikj/metrics_lazy_loaded_count (diff)
downloadsynapse-8ddd0f273c501b83b75a58e379d73aef3cfab35e.tar.xz
Comments on get_all_new_events_stream
just some docstrings to clarify the behaviour here
Diffstat (limited to 'synapse/storage/stream.py')
-rw-r--r--synapse/storage/stream.py16
1 files changed, 15 insertions, 1 deletions
diff --git a/synapse/storage/stream.py b/synapse/storage/stream.py
index 4c296d72c0..d6cfdba519 100644
--- a/synapse/storage/stream.py
+++ b/synapse/storage/stream.py
@@ -630,7 +630,21 @@ class StreamWorkerStore(EventsWorkerStore, SQLBaseStore):
 
     @defer.inlineCallbacks
     def get_all_new_events_stream(self, from_id, current_id, limit):
-        """Get all new events"""
+        """Get all new events
+
+         Returns all events with from_id < stream_ordering <= current_id.
+
+         Args:
+             from_id (int):  the stream_ordering of the last event we processed
+             current_id (int):  the stream_ordering of the most recently processed event
+             limit (int): the maximum number of events to return
+
+         Returns:
+             Deferred[Tuple[int, list[FrozenEvent]]]: A tuple of (next_id, events), where
+             `next_id` is the next value to pass as `from_id` (it will either be the
+             stream_ordering of the last returned event, or, if fewer than `limit` events
+             were found, `current_id`.
+         """
 
         def get_all_new_events_stream_txn(txn):
             sql = (