diff options
| author | Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | 2022-08-11 11:42:24 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-08-11 10:42:24 +0000 |
| commit | 507c1cb3309e989d84ec3ff9557a96ae1fc7f369 (patch) | |
| tree | d0ff6f14715ae9df656fbaff9df2d5974770b67b /synapse/storage/state.py | |
| parent | Use literals in place of `HTTPStatus` constants in tests (#13488) (diff) | |
| download | synapse-507c1cb3309e989d84ec3ff9557a96ae1fc7f369.tar.xz | |
Update the rejected state of events during resync (#13459)
Events can be un-rejected or newly-rejected during resync, so ensure we update the database and caches when that happens.
Diffstat (limited to '')
| -rw-r--r-- | synapse/storage/state.py | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/synapse/storage/state.py b/synapse/storage/state.py index af3bab2c15..0004d955b4 100644 --- a/synapse/storage/state.py +++ b/synapse/storage/state.py @@ -539,15 +539,6 @@ class StateFilter: is_mine_id: a callable which confirms if a given state_key matches a mxid of a local user """ - - # TODO(faster_joins): it's not entirely clear that this is safe. In particular, - # there may be circumstances in which we return a piece of state that, once we - # resync the state, we discover is invalid. For example: if it turns out that - # the sender of a piece of state wasn't actually in the room, then clearly that - # state shouldn't have been returned. - # We should at least add some tests around this to see what happens. - # https://github.com/matrix-org/synapse/issues/13006 - # if we haven't requested membership events, then it depends on the value of # 'include_others' if EventTypes.Member not in self.types: |