Fix 500 error when back-paginating search results

We were mistakenly adding pagination clauses to the count query, which then
failed because the count query doesn't join to the events table.

1 files changed, 4 insertions, 2 deletions

diff --git a/synapse/storage/search.py b/synapse/storage/search.py

index 57c9cc1c5f..6cb5e73b6e 100644
--- a/synapse/storage/search.py
+++ b/synapse/storage/search.py
@@ -286,8 +286,10 @@ class SearchStore(BackgroundUpdateStore):
             "(%s)" % (" OR ".join(local_clauses),)
         )
 
-        count_args = args
-        count_clauses = clauses
+        # take copies of the current args and clauses lists, before adding
+        # pagination clauses to main query.
+        count_args = list(args)
+        count_clauses = list(clauses)
 
         if pagination_token:
             try: