summary refs log tree commit diff
path: root/synapse/storage/roommember.py
diff options
context:
space:
mode:
authorErik Johnston <erikj@jki.re>2017-05-08 16:52:39 +0100
committerGitHub <noreply@github.com>2017-05-08 16:52:39 +0100
commit40dcf0d8565bbda22d6a23bd8083151e91c72306 (patch)
tree3501f762884c8a8fa4ea7ff135ff3b2d70d39bc1 /synapse/storage/roommember.py
parentMerge pull request #2201 from matrix-org/erikj/store_device_cache (diff)
parentExpand docstring a bit (diff)
downloadsynapse-40dcf0d8565bbda22d6a23bd8083151e91c72306.tar.xz
Merge pull request #2203 from matrix-org/erikj/event_cache_hit_ratio
Don't update event cache hit ratio from get_joined_users
Diffstat (limited to 'synapse/storage/roommember.py')
-rw-r--r--synapse/storage/roommember.py4
1 files changed, 4 insertions, 0 deletions
diff --git a/synapse/storage/roommember.py b/synapse/storage/roommember.py
index ad3c9b06d9..2fa20bd87c 100644
--- a/synapse/storage/roommember.py
+++ b/synapse/storage/roommember.py
@@ -421,9 +421,13 @@ class RoomMemberStore(SQLBaseStore):
         # We check if we have any of the member event ids in the event cache
         # before we ask the DB
 
+        # We don't update the event cache hit ratio as it completely throws off
+        # the hit ratio counts. After all, we don't populate the cache if we
+        # miss it here
         event_map = self._get_events_from_cache(
             member_event_ids,
             allow_rejected=False,
+            update_metrics=False,
         )
 
         missing_member_event_ids = []