diff options
| author | Erik Johnston <erik@matrix.org> | 2017-05-08 16:06:17 +0100 |
|---|---|---|
| committer | Erik Johnston <erik@matrix.org> | 2017-05-08 16:06:17 +0100 |
| commit | ffad4fe35be3baba5b2fffaa4e9b31f3008d09af (patch) | |
| tree | 726208f0cb47cbd81a1fd5009351ce4b7435f57b /synapse/storage/roommember.py | |
| parent | Increase client_ip cache size (diff) | |
| download | synapse-ffad4fe35be3baba5b2fffaa4e9b31f3008d09af.tar.xz | |
Don't update event cache hit ratio from get_joined_users
Otherwise the hit ration of plain get_events gets completely skewed by calls to get_joined_users* functions.
Diffstat (limited to 'synapse/storage/roommember.py')
| -rw-r--r-- | synapse/storage/roommember.py | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/synapse/storage/roommember.py b/synapse/storage/roommember.py index ad3c9b06d9..2fa20bd87c 100644 --- a/synapse/storage/roommember.py +++ b/synapse/storage/roommember.py @@ -421,9 +421,13 @@ class RoomMemberStore(SQLBaseStore): # We check if we have any of the member event ids in the event cache # before we ask the DB + # We don't update the event cache hit ratio as it completely throws off + # the hit ratio counts. After all, we don't populate the cache if we + # miss it here event_map = self._get_events_from_cache( member_event_ids, allow_rejected=False, + update_metrics=False, ) missing_member_event_ids = [] |