switch to setting default displayname in the storage layer

to avoid clobbering guest user displaynames on registration

1 files changed, 4 insertions, 2 deletions

diff --git a/synapse/storage/registration.py b/synapse/storage/registration.py

index 20acd58fcf..3442af4b90 100644
--- a/synapse/storage/registration.py
+++ b/synapse/storage/registration.py
@@ -177,9 +177,11 @@ class RegistrationStore(background_updates.BackgroundUpdateStore):
             )
 
         if create_profile_with_localpart:
+            # set a default displayname serverside to avoid ugly race
+            # between auto-joins and clients trying to set displaynames
             txn.execute(
-                "INSERT INTO profiles(user_id) VALUES (?)",
-                (create_profile_with_localpart,)
+                "INSERT INTO profiles(user_id, displayname) VALUES (?,?)",
+                (create_profile_with_localpart, create_profile_with_localpart)
             )
 
         self._invalidate_cache_and_stream(