diff options
| author | Erik Johnston <erik@matrix.org> | 2017-03-23 17:53:49 +0000 |
|---|---|---|
| committer | Erik Johnston <erik@matrix.org> | 2017-03-23 17:53:49 +0000 |
| commit | 00957d1aa4b01a199ab2c3abf30032a0ca0b1e12 (patch) | |
| tree | 79f6e968f784c6d4e05cda9c298d5a32fbc88291 /synapse/storage/receipts.py | |
| parent | Merge pull request #2005 from kfatehi/docs/readme (diff) | |
| download | synapse-00957d1aa4b01a199ab2c3abf30032a0ca0b1e12.tar.xz | |
User Cursor.__iter__ instead of fetchall
This prevents unnecessary construction of lists
Diffstat (limited to 'synapse/storage/receipts.py')
| -rw-r--r-- | synapse/storage/receipts.py | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/synapse/storage/receipts.py b/synapse/storage/receipts.py index 5cf41501ea..6b0f8c2787 100644 --- a/synapse/storage/receipts.py +++ b/synapse/storage/receipts.py @@ -313,10 +313,9 @@ class ReceiptsStore(SQLBaseStore): ) txn.execute(sql, (room_id, receipt_type, user_id)) - results = txn.fetchall() - if results and topological_ordering: - for to, so, _ in results: + if topological_ordering: + for to, so, _ in txn: if int(to) > topological_ordering: return False elif int(to) == topological_ordering and int(so) >= stream_ordering: |