diff options
| author | Erik Johnston <erik@matrix.org> | 2017-06-07 17:34:20 +0100 |
|---|---|---|
| committer | Erik Johnston <erik@matrix.org> | 2017-06-07 17:39:36 +0100 |
| commit | 197bd126f09b0df42b2cbb0bd7e121b04ab9d670 (patch) | |
| tree | d9ff1eaeebc879138f1982c1f51e3e8667d85baa /synapse/storage/events.py | |
| parent | Merge branch 'release-v0.21.0' of github.com:matrix-org/synapse (diff) | |
| download | synapse-197bd126f09b0df42b2cbb0bd7e121b04ab9d670.tar.xz | |
Fix bug where state_group tables got corrupted
This is due to the fact that we prefilled caches using txn.call_after, which always gets called including on error. We fix this by making txn.call_after only fire when a transaction completes successfully, which is what we want most of the time anyway.
Diffstat (limited to 'synapse/storage/events.py')
| -rw-r--r-- | synapse/storage/events.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/synapse/storage/events.py b/synapse/storage/events.py index c4aeb48800..73283eb4c7 100644 --- a/synapse/storage/events.py +++ b/synapse/storage/events.py @@ -1419,7 +1419,7 @@ class EventsStore(SQLBaseStore): ] rows = self._new_transaction( - conn, "do_fetch", [], None, self._fetch_event_rows, event_ids + conn, "do_fetch", [], [], None, self._fetch_event_rows, event_ids ) row_dict = { |