summary refs log tree commit diff
path: root/synapse/storage/events.py
diff options
context:
space:
mode:
authorRichard van der Hoff <richard@matrix.org>2018-07-26 13:19:08 +0100
committerRichard van der Hoff <richard@matrix.org>2018-07-26 13:19:08 +0100
commitbd4b25f4d07e07a2da0382cfc59a5a262883c0fc (patch)
tree8f908469fa25e1f275c11010004d0f1885983428 /synapse/storage/events.py
parentcomment on event_edges (diff)
downloadsynapse-bd4b25f4d07e07a2da0382cfc59a5a262883c0fc.tar.xz
Remove some redundant joins on event_edges.room_id
We've long passed the point where it's possible to have the same event_id in
different tables, so these join conditions are redundant: we can just join on
event_id.

event_edges is of non-trivial size, and the room_id column is wasteful, so
let's stop reading from it. In future, we can stop writing to it, and then drop
it.
Diffstat (limited to 'synapse/storage/events.py')
-rw-r--r--synapse/storage/events.py1
1 files changed, 0 insertions, 1 deletions
diff --git a/synapse/storage/events.py b/synapse/storage/events.py
index 200f5ec95f..cb10fdedc0 100644
--- a/synapse/storage/events.py
+++ b/synapse/storage/events.py
@@ -520,7 +520,6 @@ class EventsStore(EventsWorkerStore):
             iterable=list(new_latest_event_ids),
             retcols=["prev_event_id"],
             keyvalues={
-                "room_id": room_id,
                 "is_state": False,
             },
             desc="_calculate_new_extremeties",