diff options
author | Erik Johnston <erik@matrix.org> | 2019-02-18 17:53:31 +0000 |
---|---|---|
committer | Erik Johnston <erik@matrix.org> | 2019-02-18 17:53:31 +0000 |
commit | a9b5ea6fc1e26ff791118b67af01fdad8e9c68c8 (patch) | |
tree | 3fc801c2c0ba1106363da1344dffc52728335f2d /synapse/storage/events.py | |
parent | Merge pull request #4632 from matrix-org/erikj/basic_sentry (diff) | |
download | synapse-a9b5ea6fc1e26ff791118b67af01fdad8e9c68c8.tar.xz |
Batch cache invalidation over replication
Currently whenever the current state changes in a room invalidate a lot of caches, which cause *a lot* of traffic over replication. Instead, lets batch up all those invalidations and send a single poke down the replication streams. Hopefully this will reduce load on the master process by substantially reducing traffic.
Diffstat (limited to 'synapse/storage/events.py')
-rw-r--r-- | synapse/storage/events.py | 25 |
1 files changed, 1 insertions, 24 deletions
diff --git a/synapse/storage/events.py b/synapse/storage/events.py index 81b250480d..06db9e56e6 100644 --- a/synapse/storage/events.py +++ b/synapse/storage/events.py @@ -979,30 +979,7 @@ class EventsStore(StateGroupWorkerStore, EventFederationStore, EventsWorkerStore if ev_type == EventTypes.Member ) - for member in members_changed: - self._invalidate_cache_and_stream( - txn, self.get_rooms_for_user_with_stream_ordering, (member,) - ) - - for host in set(get_domain_from_id(u) for u in members_changed): - self._invalidate_cache_and_stream( - txn, self.is_host_joined, (room_id, host) - ) - self._invalidate_cache_and_stream( - txn, self.was_host_joined, (room_id, host) - ) - - self._invalidate_cache_and_stream( - txn, self.get_users_in_room, (room_id,) - ) - - self._invalidate_cache_and_stream( - txn, self.get_room_summary, (room_id,) - ) - - self._invalidate_cache_and_stream( - txn, self.get_current_state_ids, (room_id,) - ) + self._invalidate_state_caches_and_stream(txn, room_id, members_changed) def _update_forward_extremities_txn(self, txn, new_forward_extremities, max_stream_order): |