diff options
author | Eric Eastwood <erice@element.io> | 2022-08-24 14:13:12 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-08-24 14:13:12 -0500 |
commit | d58615c82cec5bd866bedcb33e3e2a5d2a961c44 (patch) | |
tree | 0c876b95db99f6c927adc011120f6953c38e7d3e /synapse/storage/databases | |
parent | When loading current ids, sort by `stream_id` to avoid incorrect overwrite an... (diff) | |
download | synapse-d58615c82cec5bd866bedcb33e3e2a5d2a961c44.tar.xz |
Directly lookup local membership instead of getting all members in a room first (`get_users_in_room` mis-use) (#13608)
See https://github.com/matrix-org/synapse/pull/13575#discussion_r953023755
Diffstat (limited to 'synapse/storage/databases')
-rw-r--r-- | synapse/storage/databases/main/roommember.py | 26 |
1 files changed, 26 insertions, 0 deletions
diff --git a/synapse/storage/databases/main/roommember.py b/synapse/storage/databases/main/roommember.py index 046ad3a11c..9e5034b401 100644 --- a/synapse/storage/databases/main/roommember.py +++ b/synapse/storage/databases/main/roommember.py @@ -534,6 +534,32 @@ class RoomMemberWorkerStore(EventsWorkerStore): desc="get_local_users_in_room", ) + async def check_local_user_in_room(self, user_id: str, room_id: str) -> bool: + """ + Check whether a given local user is currently joined to the given room. + + Returns: + A boolean indicating whether the user is currently joined to the room + + Raises: + Exeption when called with a non-local user to this homeserver + """ + if not self.hs.is_mine_id(user_id): + raise Exception( + "Cannot call 'check_local_user_in_room' on " + "non-local user %s" % (user_id,), + ) + + ( + membership, + member_event_id, + ) = await self.get_local_current_membership_for_user_in_room( + user_id=user_id, + room_id=room_id, + ) + + return membership == Membership.JOIN + async def get_local_current_membership_for_user_in_room( self, user_id: str, room_id: str ) -> Tuple[Optional[str], Optional[str]]: |