diff options
| author | Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | 2022-04-01 12:53:42 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-04-01 12:53:42 +0100 |
| commit | 9b43df1f7b2977431563b3cda8fed1ed879651ba (patch) | |
| tree | 85d0b37c2a47796a9a366839f0b2ea9e412bb55c /synapse/storage/databases | |
| parent | Add a module callback to react to account data changes (#12327) (diff) | |
| download | synapse-9b43df1f7b2977431563b3cda8fed1ed879651ba.tar.xz | |
Optimise `_get_state_after_missing_prev_event`: use `/state` (#12040)
If we're missing most of the events in the room state, then we may as well call the /state endpoint, instead of individually requesting each and every event.
Diffstat (limited to 'synapse/storage/databases')
| -rw-r--r-- | synapse/storage/databases/main/events_worker.py | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/synapse/storage/databases/main/events_worker.py b/synapse/storage/databases/main/events_worker.py index 59454a47df..a60e3f4fdd 100644 --- a/synapse/storage/databases/main/events_worker.py +++ b/synapse/storage/databases/main/events_worker.py @@ -22,7 +22,6 @@ from typing import ( Dict, Iterable, List, - NoReturn, Optional, Set, Tuple, @@ -1330,10 +1329,9 @@ class EventsWorkerStore(SQLBaseStore): return results @cached(max_entries=100000, tree=True) - async def have_seen_event(self, room_id: str, event_id: str) -> NoReturn: - # this only exists for the benefit of the @cachedList descriptor on - # _have_seen_events_dict - raise NotImplementedError() + async def have_seen_event(self, room_id: str, event_id: str) -> bool: + res = await self._have_seen_events_dict(((room_id, event_id),)) + return res[(room_id, event_id)] def _get_current_state_event_counts_txn( self, txn: LoggingTransaction, room_id: str |