diff options
| author | Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | 2022-06-09 11:13:03 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-06-09 10:13:03 +0000 |
| commit | 7c6b2204d143550d81e5bf9612c4e69fe0866b4c (patch) | |
| tree | 91c657909b18c0da55dba304b5883f617ad535a1 /synapse/storage/controllers | |
| parent | Type annotations for `test_v2` (#12985) (diff) | |
| download | synapse-7c6b2204d143550d81e5bf9612c4e69fe0866b4c.tar.xz | |
Faster joins: add issue links to the TODOs (#13004)
... to help us keep track of these things
Diffstat (limited to 'synapse/storage/controllers')
| -rw-r--r-- | synapse/storage/controllers/persist_events.py | 5 | ||||
| -rw-r--r-- | synapse/storage/controllers/state.py | 3 |
2 files changed, 7 insertions, 1 deletions
diff --git a/synapse/storage/controllers/persist_events.py b/synapse/storage/controllers/persist_events.py index 4caaa81808..4bcb99d06e 100644 --- a/synapse/storage/controllers/persist_events.py +++ b/synapse/storage/controllers/persist_events.py @@ -388,10 +388,13 @@ class EventsPersistenceStorageController: # TODO(faster_joins): get a real stream ordering, to make this work correctly # across workers. + # https://github.com/matrix-org/synapse/issues/12994 # # TODO(faster_joins): this can race against event persistence, in which case we # will end up with incorrect state. Perhaps we should make this a job we - # farm out to the event persister, somehow. + # farm out to the event persister thread, somehow. + # https://github.com/matrix-org/synapse/issues/13007 + # stream_id = self.main_store.get_room_max_stream_ordering() await self.persist_events_store.update_current_state(room_id, delta, stream_id) diff --git a/synapse/storage/controllers/state.py b/synapse/storage/controllers/state.py index 3b4cdb67eb..d3a44bc876 100644 --- a/synapse/storage/controllers/state.py +++ b/synapse/storage/controllers/state.py @@ -452,6 +452,9 @@ class StateStorageController: up to date. """ # FIXME(faster_joins): what do we do here? + # https://github.com/matrix-org/synapse/issues/12814 + # https://github.com/matrix-org/synapse/issues/12815 + # https://github.com/matrix-org/synapse/issues/13008 return await self.stores.main.get_partial_current_state_deltas( prev_stream_id, max_stream_id |