summary refs log tree commit diff
path: root/synapse/state
diff options
context:
space:
mode:
authorNick Mills-Barrett <nick@beeper.com>2022-08-23 10:49:59 +0100
committerGitHub <noreply@github.com>2022-08-23 09:49:59 +0000
commit5e7847dc923142bc68834f9b9538ada3fdd887d5 (patch)
tree4034cac25dfc9f94e3f25b8ee199ced9f4b764f4 /synapse/state
parentFix that sending server notices fail if avatar is `None` (#13566) (diff)
downloadsynapse-5e7847dc923142bc68834f9b9538ada3fdd887d5.tar.xz
Cache user IDs instead of profile objects (#13573)
The profile objects are never used and increase cache size significantly.
Diffstat (limited to 'synapse/state')
-rw-r--r--synapse/state/__init__.py13
1 files changed, 6 insertions, 7 deletions
diff --git a/synapse/state/__init__.py b/synapse/state/__init__.py

index c355e4f98a..3047e1b1ad 100644 --- a/synapse/state/__init__.py +++ b/synapse/state/__init__.py
@@ -44,7 +44,6 @@ from synapse.logging.context import ContextResourceUsage from synapse.replication.http.state import ReplicationUpdateCurrentStateRestServlet from synapse.state import v1, v2 from synapse.storage.databases.main.events_worker import EventRedactBehaviour -from synapse.storage.roommember import ProfileInfo from synapse.storage.state import StateFilter from synapse.types import StateMap from synapse.util.async_helpers import Linearizer @@ -210,11 +209,11 @@ class StateHandler: ret = await self.resolve_state_groups_for_events(room_id, event_ids) return await ret.get_state(self._state_storage_controller, state_filter) - async def get_current_users_in_room( + async def get_current_user_ids_in_room( self, room_id: str, latest_event_ids: List[str] - ) -> Dict[str, ProfileInfo]: + ) -> Set[str]: """ - Get the users who are currently in a room. + Get the users IDs who are currently in a room. Note: This is much slower than using the equivalent method `DataStore.get_users_in_room` or `DataStore.get_users_in_room_with_profiles`, @@ -225,15 +224,15 @@ class StateHandler: room_id: The ID of the room. latest_event_ids: Precomputed list of latest event IDs. Will be computed if None. Returns: - Dictionary of user IDs to their profileinfo. + Set of user IDs in the room. """ assert latest_event_ids is not None - logger.debug("calling resolve_state_groups from get_current_users_in_room") + logger.debug("calling resolve_state_groups from get_current_user_ids_in_room") entry = await self.resolve_state_groups_for_events(room_id, latest_event_ids) state = await entry.get_state(self._state_storage_controller, StateFilter.all()) - return await self.store.get_joined_users_from_state(room_id, state, entry) + return await self.store.get_joined_user_ids_from_state(room_id, state, entry) async def get_hosts_in_room_at_events( self, room_id: str, event_ids: Collection[str]