diff options
| author | Sean Quah <8349537+squahtx@users.noreply.github.com> | 2023-02-10 23:29:00 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-10 23:29:00 +0000 |
| commit | d0c713cc85f094c323b2ba3f02d8ac411a7f0705 (patch) | |
| tree | c26f279f53c76ea9adb74853d11cfd264675eeb5 /synapse/state/__init__.py | |
| parent | Support for MSC3758: exact_event_match push condition (#14964) (diff) | |
| download | synapse-d0c713cc85f094c323b2ba3f02d8ac411a7f0705.tar.xz | |
Return read-only collections from `@cached` methods (#13755)
It's important that collections returned from `@cached` methods are not modified, otherwise future retrievals from the cache will return the modified collection. This applies to the return values from `@cached` methods and the values inside the dictionaries returned by `@cachedList` methods. It's not necessary for the dictionaries returned by `@cachedList` methods themselves to be read-only. Signed-off-by: Sean Quah <seanq@matrix.org> Co-authored-by: David Robertson <davidr@element.io>
Diffstat (limited to 'synapse/state/__init__.py')
| -rw-r--r-- | synapse/state/__init__.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/synapse/state/__init__.py b/synapse/state/__init__.py index e877e6f1a1..4dc25df67e 100644 --- a/synapse/state/__init__.py +++ b/synapse/state/__init__.py @@ -226,7 +226,7 @@ class StateHandler: return await ret.get_state(self._state_storage_controller, state_filter) async def get_current_user_ids_in_room( - self, room_id: str, latest_event_ids: List[str] + self, room_id: str, latest_event_ids: Collection[str] ) -> Set[str]: """ Get the users IDs who are currently in a room. |