summary refs log tree commit diff
path: root/synapse/server_notices
diff options
context:
space:
mode:
authorRichard van der Hoff <1389908+richvdh@users.noreply.github.com>2020-09-25 12:29:54 +0100
committerGitHub <noreply@github.com>2020-09-25 12:29:54 +0100
commitfec6f9ac178867a8e7c5410e0d25898f29bab35c (patch)
treeab127833049cd146c96a2fea7c85f116c26ec3ea /synapse/server_notices
parentAllow existing users to login via OpenID Connect. (#8345) (diff)
downloadsynapse-fec6f9ac178867a8e7c5410e0d25898f29bab35c.tar.xz
Fix occasional "Re-starting finished log context" from keyring (#8398)
* Fix test_verify_json_objects_for_server_awaits_previous_requests

It turns out that this wasn't really testing what it thought it was testing
(in particular, `check_context` was turning failures into success, which was
making the tests pass even though it wasn't clear they should have been.

It was also somewhat overcomplex - we can test what it was trying to test
without mocking out perspectives servers.

* Fix warnings about finished logcontexts in the keyring

We need to make sure that we finish the key fetching magic before we run the
verifying code, to ensure that we don't mess up our logcontexts.
Diffstat (limited to 'synapse/server_notices')
0 files changed, 0 insertions, 0 deletions