diff options
| author | Erik Johnston <erikj@jki.re> | 2018-10-25 17:49:55 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-10-25 17:49:55 +0100 |
| commit | cb53ce9d6429252d5ee012f5a476cc834251c27d (patch) | |
| tree | 90be05442144fa134496da612e850855e2c84b18 /synapse/rest | |
| parent | Merge remote-tracking branch 'origin/master' into develop (diff) | |
| download | synapse-cb53ce9d6429252d5ee012f5a476cc834251c27d.tar.xz | |
Refactor state group lookup to reduce DB hits (#4011)
Currently when fetching state groups from the data store we make two hits two the database: once for members and once for non-members (unless request is filtered to one or the other). This adds needless load to the datbase, so this PR refactors the lookup to make only a single database hit.
Diffstat (limited to 'synapse/rest')
| -rw-r--r-- | synapse/rest/client/v1/room.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/synapse/rest/client/v1/room.py b/synapse/rest/client/v1/room.py index 663934efd0..fcfe7857f6 100644 --- a/synapse/rest/client/v1/room.py +++ b/synapse/rest/client/v1/room.py @@ -33,6 +33,7 @@ from synapse.http.servlet import ( parse_json_object_from_request, parse_string, ) +from synapse.storage.state import StateFilter from synapse.streams.config import PaginationConfig from synapse.types import RoomAlias, RoomID, StreamToken, ThirdPartyInstanceID, UserID @@ -409,7 +410,7 @@ class RoomMemberListRestServlet(ClientV1RestServlet): room_id=room_id, user_id=requester.user.to_string(), at_token=at_token, - types=[(EventTypes.Member, None)], + state_filter=StateFilter.from_types([(EventTypes.Member, None)]), ) chunk = [] |