Consistently use six's iteritems and wrap lazy keys/values in list() if they're not meant to be lazy (#3307)

1 files changed, 1 insertions, 1 deletions

diff --git a/synapse/rest/client/transactions.py b/synapse/rest/client/transactions.py

index 20fa6678ef..7c01b438cb 100644
--- a/synapse/rest/client/transactions.py
+++ b/synapse/rest/client/transactions.py
@@ -104,7 +104,7 @@ class HttpTransactionCache(object):
 
     def _cleanup(self):
         now = self.clock.time_msec()
-        for key in self.transactions.keys():
+        for key in list(self.transactions):
             ts = self.transactions[key][1]
             if now > (ts + CLEANUP_PERIOD_MS):  # after cleanup period
                 del self.transactions[key]