diff options
| author | Erik Johnston <erik@matrix.org> | 2018-09-21 14:19:46 +0100 |
|---|---|---|
| committer | Erik Johnston <erik@matrix.org> | 2018-09-21 14:19:46 +0100 |
| commit | 8601c24287c452c0d9a803b130e0f68cf6169f6a (patch) | |
| tree | 5651cf7a06b3be5db0d04a61cf94bf4eddc843ba /synapse/rest/media/v1 | |
| parent | Merge pull request #3927 from matrix-org/erikj/handle_background_errors (diff) | |
| download | synapse-8601c24287c452c0d9a803b130e0f68cf6169f6a.tar.xz | |
Fix some instances of ExpiringCache not expiring cache items
ExpiringCache required that `start()` be called before it would actually start expiring entries. A number of places didn't do that. This PR removes `start` from ExpiringCache, and automatically starts backround reaping process on creation instead.
Diffstat (limited to 'synapse/rest/media/v1')
| -rw-r--r-- | synapse/rest/media/v1/preview_url_resource.py | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/synapse/rest/media/v1/preview_url_resource.py b/synapse/rest/media/v1/preview_url_resource.py index cad2dec33a..af01040a38 100644 --- a/synapse/rest/media/v1/preview_url_resource.py +++ b/synapse/rest/media/v1/preview_url_resource.py @@ -79,7 +79,6 @@ class PreviewUrlResource(Resource): # don't spider URLs more often than once an hour expiry_ms=60 * 60 * 1000, ) - self._cache.start() self._cleaner_loop = self.clock.looping_call( self._start_expire_url_cache_data, 10 * 1000, |