diff options
| author | Mark Haines <mark.haines@matrix.org> | 2015-08-28 11:15:27 +0100 |
|---|---|---|
| committer | Mark Haines <mark.haines@matrix.org> | 2015-08-28 11:15:27 +0100 |
| commit | a7122692d972ce3ac787d4ecf1449f87f33e83cf (patch) | |
| tree | 81ece372c764d775d1d10cc581100de006456d67 /synapse/rest/media/v1/upload_resource.py | |
| parent | Merge pull request #254 from matrix-org/markjh/tox_setuptools (diff) | |
| parent | Bump version and changelog (diff) | |
| download | synapse-a7122692d972ce3ac787d4ecf1449f87f33e83cf.tar.xz | |
Merge branch 'release-v0.10.0' into develop
Conflicts: synapse/handlers/auth.py synapse/python_dependencies.py synapse/rest/client/v1/login.py
Diffstat (limited to 'synapse/rest/media/v1/upload_resource.py')
| -rw-r--r-- | synapse/rest/media/v1/upload_resource.py | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/synapse/rest/media/v1/upload_resource.py b/synapse/rest/media/v1/upload_resource.py index 439d5a30a8..6abaf56b25 100644 --- a/synapse/rest/media/v1/upload_resource.py +++ b/synapse/rest/media/v1/upload_resource.py @@ -15,7 +15,7 @@ from synapse.http.server import respond_with_json, request_handler -from synapse.util.stringutils import random_string, is_ascii +from synapse.util.stringutils import random_string from synapse.api.errors import SynapseError from twisted.web.server import NOT_DONE_YET @@ -86,9 +86,13 @@ class UploadResource(BaseMediaResource): upload_name = request.args.get("filename", None) if upload_name: - upload_name = upload_name[0] - if upload_name and not is_ascii(upload_name): - raise SynapseError(400, "filename must be ascii") + try: + upload_name = upload_name[0].decode('UTF-8') + except UnicodeDecodeError: + raise SynapseError( + msg="Invalid UTF-8 filename parameter: %r" % (upload_name), + code=400, + ) headers = request.requestHeaders |