diff options
| author | David Baker <dave@matrix.org> | 2019-05-10 10:52:24 +0100 |
|---|---|---|
| committer | David Baker <dave@matrix.org> | 2019-05-10 10:52:24 +0100 |
| commit | 085ae346ace418e0fc043ac5f568f85ebf80038e (patch) | |
| tree | b2ca3294e08739ec12406a1212f263cbf710bc00 /synapse/rest/client | |
| parent | Make Prometheus snippet less confusing on the metrics collection doc (#4288) (diff) | |
| download | synapse-085ae346ace418e0fc043ac5f568f85ebf80038e.tar.xz | |
Add a DUMMY stage to captcha-only registration flow
This allows the client to complete the email last which is more natual for the user. Without this stage, if the client would complete the recaptcha (and terms, if enabled) stages and then the registration request would complete because you've now completed a flow, even if you were intending to complete the flow that's the same except has email auth at the end. Adding a dummy auth stage to the recaptcha-only flow means it's always unambiguous which flow the client was trying to complete. Longer term we should think about changing the protocol so the client explicitly says which flow it's trying to complete. https://github.com/vector-im/riot-web/issues/9586
Diffstat (limited to 'synapse/rest/client')
| -rw-r--r-- | synapse/rest/client/v2_alpha/register.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/synapse/rest/client/v2_alpha/register.py b/synapse/rest/client/v2_alpha/register.py index dc3e265bcd..95578b76ae 100644 --- a/synapse/rest/client/v2_alpha/register.py +++ b/synapse/rest/client/v2_alpha/register.py @@ -345,7 +345,7 @@ class RegisterRestServlet(RestServlet): if self.hs.config.enable_registration_captcha: # only support 3PIDless registration if no 3PIDs are required if not require_email and not require_msisdn: - flows.extend([[LoginType.RECAPTCHA]]) + flows.extend([[LoginType.RECAPTCHA, LoginType.DUMMY]]) # only support the email-only flow if we don't require MSISDN 3PIDs if not require_msisdn: flows.extend([[LoginType.EMAIL_IDENTITY, LoginType.RECAPTCHA]]) |