summary refs log tree commit diff
path: root/synapse/replication/tcp/streams
diff options
context:
space:
mode:
authorErik Johnston <erikj@matrix.org>2023-10-30 14:47:57 +0000
committerGitHub <noreply@github.com>2023-10-30 14:47:57 +0000
commit408c13801a244a89d23f9c8e8ccce1b3d049abb6 (patch)
tree18dce9160b0fe2c516db6dd3afb155ca4a5f0513 /synapse/replication/tcp/streams
parentClaim fallback keys in bulk (#16570) (diff)
downloadsynapse-408c13801a244a89d23f9c8e8ccce1b3d049abb6.tar.xz
Add fast path for replication events stream fetch (#16580)
We can bail early if the from token is greater than or equal to the
current token.
Diffstat (limited to 'synapse/replication/tcp/streams')
-rw-r--r--synapse/replication/tcp/streams/events.py6
1 files changed, 6 insertions, 0 deletions
diff --git a/synapse/replication/tcp/streams/events.py b/synapse/replication/tcp/streams/events.py
index 38823113d8..57138fea80 100644
--- a/synapse/replication/tcp/streams/events.py
+++ b/synapse/replication/tcp/streams/events.py
@@ -157,6 +157,12 @@ class EventsStream(_StreamFromIdGen):
         current_token: Token,
         target_row_count: int,
     ) -> StreamUpdateResult:
+        # The events stream cannot be "reset", so its safe to return early if
+        # the from token is larger than the current token (the DB query will
+        # trivially return 0 rows anyway).
+        if from_token >= current_token:
+            return [], current_token, False
+
         # the events stream merges together three separate sources:
         #  * new events
         #  * current_state changes