diff options
| author | David Robertson <davidr@element.io> | 2021-09-30 12:51:47 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-09-30 12:51:47 +0100 |
| commit | 29364145b29e84c5dcab076c4e0d436ebf77e4cd (patch) | |
| tree | 23ef1af431c4629bf973560c86a5cf801e80b3a5 /synapse/replication/tcp/handler.py | |
| parent | Refactor user directory tests (#10935) (diff) | |
| download | synapse-29364145b29e84c5dcab076c4e0d436ebf77e4cd.tar.xz | |
Pass str to twisted's IReactorTCP (#10895)
This follows a correction made in twisted/twisted#1664 and should fix our Twisted Trial CI job. Until that change is in a twisted release, we'll have to ignore the type of the `host` argument. I've raised #10899 to remind us to review the issue in a few months' time.
Diffstat (limited to 'synapse/replication/tcp/handler.py')
| -rw-r--r-- | synapse/replication/tcp/handler.py | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/synapse/replication/tcp/handler.py b/synapse/replication/tcp/handler.py index 1438a82b60..d64d1dbacd 100644 --- a/synapse/replication/tcp/handler.py +++ b/synapse/replication/tcp/handler.py @@ -315,7 +315,7 @@ class ReplicationCommandHandler: hs, outbound_redis_connection ) hs.get_reactor().connectTCP( - hs.config.redis.redis_host.encode(), + hs.config.redis.redis_host, # type: ignore[arg-type] hs.config.redis.redis_port, self._factory, ) @@ -324,7 +324,11 @@ class ReplicationCommandHandler: self._factory = DirectTcpReplicationClientFactory(hs, client_name, self) host = hs.config.worker.worker_replication_host port = hs.config.worker.worker_replication_port - hs.get_reactor().connectTCP(host.encode(), port, self._factory) + hs.get_reactor().connectTCP( + host, # type: ignore[arg-type] + port, + self._factory, + ) def get_streams(self) -> Dict[str, Stream]: """Get a map from stream name to all streams.""" |