diff options
| author | Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | 2020-04-22 22:39:04 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-04-22 22:39:04 +0100 |
| commit | 71a1abb8a116372556fd577ff1b85c7cfbe3c2b3 (patch) | |
| tree | afedbf8d0769498f35a2bb210a2cc87a31206267 /synapse/replication/tcp/commands.py | |
| parent | Fix replication metrics when using redis (#7325) (diff) | |
| download | synapse-71a1abb8a116372556fd577ff1b85c7cfbe3c2b3.tar.xz | |
Stop the master relaying USER_SYNC for other workers (#7318)
Long story short: if we're handling presence on the current worker, we shouldn't be sending USER_SYNC commands over replication. In an attempt to figure out what is going on here, I ended up refactoring some bits of the presencehandler code, so the first 4 commits here are non-functional refactors to move this code slightly closer to sanity. (There's still plenty to do here :/). Suggest reviewing individual commits. Fixes (I hope) #7257.
Diffstat (limited to 'synapse/replication/tcp/commands.py')
| -rw-r--r-- | synapse/replication/tcp/commands.py | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/synapse/replication/tcp/commands.py b/synapse/replication/tcp/commands.py index f26aee83cb..c7880d4b63 100644 --- a/synapse/replication/tcp/commands.py +++ b/synapse/replication/tcp/commands.py @@ -210,7 +210,10 @@ class ReplicateCommand(Command): class UserSyncCommand(Command): """Sent by the client to inform the server that a user has started or - stopped syncing. Used to calculate presence on the master. + stopped syncing on this process. + + This is used by the process handling presence (typically the master) to + calculate who is online and who is not. Includes a timestamp of when the last user sync was. @@ -218,7 +221,7 @@ class UserSyncCommand(Command): USER_SYNC <instance_id> <user_id> <state> <last_sync_ms> - Where <state> is either "start" or "stop" + Where <state> is either "start" or "end" """ NAME = "USER_SYNC" |