diff options
| author | Erik Johnston <erik@matrix.org> | 2020-05-13 10:27:02 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-05-13 10:27:02 +0100 |
| commit | 7ee24c5674a36dc9cd7163cfdd3e14b74570dc77 (patch) | |
| tree | a6676da63007e1cdde559db9d74ecd6d1ff5b8cd /synapse/replication/http | |
| parent | Fix Redis reconnection logic (#7482) (diff) | |
| download | synapse-7ee24c5674a36dc9cd7163cfdd3e14b74570dc77.tar.xz | |
Have all instances correctly respond to REPLICATE command. (#7475)
Before all streams were only written to from master, so only master needed to respond to `REPLICATE` commands. Before all instances wrote to the cache invalidation stream, but didn't respond to `REPLICATE`. This was a bug, which could lead to missed rows from cache invalidation stream if an instance is restarted, however all the caches would be empty in that case so it wasn't a problem.
Diffstat (limited to 'synapse/replication/http')
| -rw-r--r-- | synapse/replication/http/streams.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/synapse/replication/http/streams.py b/synapse/replication/http/streams.py index 0459f582bf..b705a8e16c 100644 --- a/synapse/replication/http/streams.py +++ b/synapse/replication/http/streams.py @@ -52,9 +52,9 @@ class ReplicationGetStreamUpdates(ReplicationEndpoint): self._instance_name = hs.get_instance_name() - # We pull the streams from the replication steamer (if we try and make + # We pull the streams from the replication handler (if we try and make # them ourselves we end up in an import loop). - self.streams = hs.get_replication_streamer().get_streams() + self.streams = hs.get_tcp_replication().get_streams() @staticmethod def _serialize_payload(stream_name, from_token, upto_token): |