diff options
| author | Erik Johnston <erikj@matrix.org> | 2023-10-23 16:57:30 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-10-23 16:57:30 +0100 |
| commit | 8f35f8148e1a7ce3ac249e2d2052854409f2c0d6 (patch) | |
| tree | 72eb736c64970a416e07c123a4b350614dc1518d /synapse/replication/http/_base.py | |
| parent | Fix bug that could cause a `/sync` to tightloop with sqlite after restart (#1... (diff) | |
| download | synapse-8f35f8148e1a7ce3ac249e2d2052854409f2c0d6.tar.xz | |
Fix bug where a new writer advances their token too quickly (#16473)
* Fix bug where a new writer advances their token too quickly When starting a new writer (for e.g. persisting events), the `MultiWriterIdGenerator` doesn't have a minimum token for it as there are no rows matching that new writer in the DB. This results in the the first stream ID it acquired being announced as persisted *before* it actually finishes persisting, if another writer gets and persists a subsequent stream ID. This is due to the logic of setting the minimum persisted position to the minimum known position of across all writers, and the new writer starts off not being considered. * Fix sending out POSITIONs when our token advances without update Broke in #14820 * For replication HTTP requests, only wait for minimal position
Diffstat (limited to 'synapse/replication/http/_base.py')
| -rw-r--r-- | synapse/replication/http/_base.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/synapse/replication/http/_base.py b/synapse/replication/http/_base.py index 63cf24a14d..7476839db5 100644 --- a/synapse/replication/http/_base.py +++ b/synapse/replication/http/_base.py @@ -238,7 +238,7 @@ class ReplicationEndpoint(metaclass=abc.ABCMeta): data[_STREAM_POSITION_KEY] = { "streams": { - stream.NAME: stream.current_token(local_instance_name) + stream.NAME: stream.minimal_local_current_token() for stream in streams }, "instance_name": local_instance_name, |