summary refs log tree commit diff
path: root/synapse/push
diff options
context:
space:
mode:
authorErik Johnston <erik@matrix.org>2019-12-04 10:16:44 +0000
committerErik Johnston <erik@matrix.org>2019-12-04 16:23:43 +0000
commitc2f525a5251f4cbaef0cf34d6c69b42356c1f8af (patch)
tree7bc4c79a2f3ce1bdd38a95ba2480a73ad0fb8f93 /synapse/push
parentMerge pull request #6454 from matrix-org/erikj/clean_base_Store (diff)
downloadsynapse-c2f525a5251f4cbaef0cf34d6c69b42356c1f8af.tar.xz
Don't call SQLBaseStore methods from outside stores
Diffstat (limited to 'synapse/push')
-rw-r--r--synapse/push/bulk_push_rule_evaluator.py10
1 files changed, 1 insertions, 9 deletions
diff --git a/synapse/push/bulk_push_rule_evaluator.py b/synapse/push/bulk_push_rule_evaluator.py
index 1ba7bcd4d8..7881780760 100644
--- a/synapse/push/bulk_push_rule_evaluator.py
+++ b/synapse/push/bulk_push_rule_evaluator.py
@@ -386,15 +386,7 @@ class RulesForRoom(object):
         """
         sequence = self.sequence
 
-        rows = yield self.store._simple_select_many_batch(
-            table="room_memberships",
-            column="event_id",
-            iterable=member_event_ids.values(),
-            retcols=("user_id", "membership", "event_id"),
-            keyvalues={},
-            batch_size=500,
-            desc="_get_rules_for_member_event_ids",
-        )
+        rows = yield self.store.get_membership_from_event_ids(member_event_ids.values())
 
         members = {row["event_id"]: (row["user_id"], row["membership"]) for row in rows}