diff options
author | Erik Johnston <erik@matrix.org> | 2017-04-25 14:38:51 +0100 |
---|---|---|
committer | Erik Johnston <erik@matrix.org> | 2017-04-25 14:38:51 +0100 |
commit | d9aa645f86db733bb0419b5f5428ba9a9c799735 (patch) | |
tree | 3bd3cc61f7656609e6642351014401b20f2882c8 /synapse/push | |
parent | Reduce _get_state_group_for_event cache size (diff) | |
download | synapse-d9aa645f86db733bb0419b5f5428ba9a9c799735.tar.xz |
Reduce size of joined_user cache
The _get_joined_users_from_context cache stores a mapping from user_id to avatar_url and display_name. Instead of storing those in a dict, store them in a namedtuple as that uses much less memory. We also try converting the string to ascii to further reduce the size.
Diffstat (limited to 'synapse/push')
-rw-r--r-- | synapse/push/bulk_push_rule_evaluator.py | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/synapse/push/bulk_push_rule_evaluator.py b/synapse/push/bulk_push_rule_evaluator.py index 78b095c903..503fef4261 100644 --- a/synapse/push/bulk_push_rule_evaluator.py +++ b/synapse/push/bulk_push_rule_evaluator.py @@ -87,8 +87,11 @@ class BulkPushRuleEvaluator: condition_cache = {} for uid, rules in self.rules_by_user.items(): - display_name = room_members.get(uid, {}).get("display_name", None) - if not display_name: + display_name = None + profile_info = room_members.get(uid, {}) + if profile_info: + display_name = profile_info.display_name + else: # Handle the case where we are pushing a membership event to # that user, as they might not be already joined. if event.type == EventTypes.Member and event.state_key == uid: |