diff options
| author | Erik Johnston <erik@matrix.org> | 2022-05-10 20:43:13 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-05-10 19:43:13 +0000 |
| commit | c72d26c1e1e997e63cef1c474010a7db783f8022 (patch) | |
| tree | 212afc2b3104f8bbf664c65d49fd59698864a822 /synapse/push/action_generator.py | |
| parent | Capture the `Deferred` for request cancellation in `_AsyncResource` (#12694) (diff) | |
| download | synapse-c72d26c1e1e997e63cef1c474010a7db783f8022.tar.xz | |
Refactor `EventContext` (#12689)
Refactor how the `EventContext` class works, with the intention of reducing the amount of state we fetch from the DB during event processing. The idea here is to get rid of the cached `current_state_ids` and `prev_state_ids` that live in the `EventContext`, and instead defer straight to the database (and its caching). One change that may have a noticeable effect is that we now no longer prefill the `get_current_state_ids` cache on a state change. However, that query is relatively light, since its just a case of reading a table from the DB (unlike fetching state at an event which is more heavyweight). For deployments with workers this cache isn't even used. Part of #12684
Diffstat (limited to 'synapse/push/action_generator.py')
| -rw-r--r-- | synapse/push/action_generator.py | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/synapse/push/action_generator.py b/synapse/push/action_generator.py index 60758df016..730d9cd354 100644 --- a/synapse/push/action_generator.py +++ b/synapse/push/action_generator.py @@ -40,5 +40,9 @@ class ActionGenerator: async def handle_push_actions_for_event( self, event: EventBase, context: EventContext ) -> None: + if event.internal_metadata.is_outlier(): + # This can happen due to out of band memberships + return + with Measure(self.clock, "action_for_event_by_user"): await self.bulk_evaluator.action_for_event_by_user(event, context) |